bpo-39815: add cached_property to all by hakancelikdev · Pull Request #18726 · python/cpython

hakancelikdev · 2020-03-01T20:11:47Z

https://bugs.python.org/issue39815

Automerge-Triggered-By: @pablogsal

isidentical

LGTM

pablogsal

Thanks for the PR. Just a minor comment, otherwise LGTM

pablogsal · 2020-03-01T20:40:37Z

Could you move this to the next line so the line remains no longer than ~80 chars?

bedevere-bot · 2020-03-01T20:41:14Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hakancelikdev · 2020-03-01T20:45:12Z

I have made the requested changes; please review again

bedevere-bot · 2020-03-01T20:45:15Z

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

pablogsal · 2020-03-01T20:45:46Z

Thanks for the PR, @hakancelik96 !

codecov · 2020-03-01T20:45:54Z

Codecov Report

Merging #18726 into master will decrease coverage by 1.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18726       +/-   ##
===========================================
- Coverage   83.28%   82.13%    -1.15%     
===========================================
  Files        1571     1955      +384     
  Lines      415244   584723   +169479     
  Branches    44484    44489        +5     
===========================================
+ Hits       345821   480266   +134445     
- Misses      59773    94808    +35035     
+ Partials     9650     9649        -1

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 435 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768d739...a6f350f. Read the comment docs.

hakancelikdev · 2020-03-01T20:48:20Z

Thanks for the PR, @hakancelik96 !

You are welcome.
Thanks for the review @pablogsal and helping of @isidentical. 💯

miss-islington · 2020-03-01T21:01:33Z

@hakancelik96: Status check is done, and it's a success ✅ .

miss-islington · 2020-03-01T21:01:38Z

Thanks @hakancelik96 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington · 2020-03-01T21:01:43Z

Sorry @hakancelik96, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 217dce9ee6e3cf27a0cedbe1e4a6455776373ec2 3.8

bpo-39815: add cached_property to all (pythonGH-18726)

bedevere-bot · 2020-03-01T23:40:44Z

GH-18728 is a backport of this pull request to the 3.8 branch.

@pablogsal

Automerge-Triggered-By: @pablogsal. (cherry picked from commit 217dce9) Co-authored-by: Hakan Çelik <hakancelik96@outlook.com>

@pablogsal

Automerge-Triggered-By: @pablogsal. (cherry picked from commit 217dce9) Co-authored-by: Hakan Çelik <hakancelik96@outlook.com>

bedevere-bot · 2020-03-02T04:10:49Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO + PGO 3.8 has failed when building commit 12b7143.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/392/builds/33) and take a look at the build logs.
Check if the failure is related to this commit (12b7143) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/392/builds/33

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 5, done.        
remote: Counting objects:  20% (1/5)        
remote: Counting objects:  40% (2/5)        
remote: Counting objects:  60% (3/5)        
remote: Counting objects:  80% (4/5)        
remote: Counting objects: 100% (5/5)        
remote: Counting objects: 100% (5/5), done.        
remote: Total 6 (delta 5), reused 5 (delta 5), pack-reused 1        
From https://github.com/python/cpython
 * branch                  3.8        -> FETCH_HEAD
Reset branch '3.8'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:1778: clean] Error 1 (ignored)

I have noticed that `'` quotes are used everywhere except this particular case, which was introduced in python#18726 So, this is a simple fix to enforce better consistency.

I have noticed that `'` quotes are used everywhere except this particular case, which was introduced in #18726 So, this is a trivial fix to enforce better consistency.

hakancelikdev requested a review from rhettinger as a code owner March 1, 2020 20:11

the-knights-who-say-ni added the CLA signed label Mar 1, 2020

bedevere-bot added the awaiting review label Mar 1, 2020

hakancelikdev changed the title ~~Bpo 39815~~ Bpo 39815 - add cached_property to all Mar 1, 2020

hakancelikdev changed the title ~~Bpo 39815 - add cached_property to all~~ bpo-39815 - add cached_property to all Mar 1, 2020

hakancelikdev changed the title ~~bpo-39815 - add cached_property to all~~ bpo-39815: add cached_property to all Mar 1, 2020

isidentical added skip issue skip news and removed skip issue labels Mar 1, 2020

isidentical approved these changes Mar 1, 2020

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Mar 1, 2020

pablogsal requested changes Mar 1, 2020

View reviewed changes

bedevere-bot removed the awaiting core review label Mar 1, 2020

bedevere-bot added the awaiting changes label Mar 1, 2020

bpo-39815: add cached_property to all

a6f350f

pablogsal added the needs backport to 3.8 label Mar 1, 2020

bedevere-bot added awaiting change review and removed awaiting changes labels Mar 1, 2020

bedevere-bot requested a review from pablogsal March 1, 2020 20:45

pablogsal approved these changes Mar 1, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Mar 1, 2020

pablogsal added the 🤖 automerge label Mar 1, 2020

miss-islington merged commit 217dce9 into python:master Mar 1, 2020

bedevere-bot removed the awaiting merge label Mar 1, 2020

miss-islington self-assigned this Mar 1, 2020

sthagen added a commit to sthagen/python-cpython that referenced this pull request Mar 1, 2020

Merge pull request #290 from python/master

97b72e8

bpo-39815: add cached_property to all (pythonGH-18726)

bedevere-bot removed the needs backport to 3.8 label Mar 1, 2020

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Mar 1, 2020

[3.8] bpo-39815: add cached_property to all (pythonGH-18726)

dac5a02

Automerge-Triggered-By: @pablogsal. (cherry picked from commit 217dce9) Co-authored-by: Hakan Çelik <hakancelik96@outlook.com>

pablogsal added a commit that referenced this pull request Mar 2, 2020

[3.8] bpo-39815: add cached_property to all (GH-18726) (GH-18728)

12b7143

Automerge-Triggered-By: @pablogsal. (cherry picked from commit 217dce9) Co-authored-by: Hakan Çelik <hakancelik96@outlook.com>

This comment has been minimized.

Sign in to view

sobolevn mentioned this pull request Mar 7, 2020

Updates functools.py with consistent quotes #18825

Merged

Uh oh!

Uh oh!

Conversation

hakancelikdev commented Mar 1, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isidentical left a comment

Choose a reason for hiding this comment

Uh oh!

pablogsal left a comment

Choose a reason for hiding this comment

Uh oh!

pablogsal Mar 1, 2020

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Mar 1, 2020

Uh oh!

hakancelikdev commented Mar 1, 2020

Uh oh!

bedevere-bot commented Mar 1, 2020

Uh oh!

pablogsal commented Mar 1, 2020

Uh oh!

codecov Bot commented Mar 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hakancelikdev commented Mar 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Mar 1, 2020

Uh oh!

miss-islington commented Mar 1, 2020

Uh oh!

miss-islington commented Mar 1, 2020

Uh oh!

bedevere-bot commented Mar 1, 2020

Uh oh!

This comment has been minimized.

bedevere-bot commented Mar 2, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hakancelikdev commented Mar 1, 2020 •

edited by miss-islington

Loading

codecov Bot commented Mar 1, 2020 •

edited

Loading

hakancelikdev commented Mar 1, 2020 •

edited

Loading